-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Typescript-angular support single request param #4479
feature: Typescript-angular support single request param #4479
Conversation
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07) Please have a look :) |
*/ | ||
public addPet(body: Pet, extraHttpRequestParams?: RequestOptionsArgs): Observable<{}> { | ||
return this.addPetWithHttpInfo(body, extraHttpRequestParams) | ||
public addPet(pet: Pet, extraHttpRequestParams?: RequestOptionsArgs): Observable<{}> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't run the bin/openapi3
scripts
thanks for the PR, I will have a closer look soon |
This reverts commit 8c5bfd9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think we should include it and have a look at the user feedback.
@djairhogeuens can you please commit the executable flag of the newly added script in /bin? |
The executable flag was set, I did notice a small mistake in the script itself when comparing it to the windows version. I ran them both locally and they seem to work fine so I commited that fix and will see if CI passes now. |
the executable flag is still missing: see https://github.com/OpenAPITools/openapi-generator/blob/4083448afd40c84e2c2784e5e929f679be4f3b6f/bin/typescript-angular-petstore-all.sh for reference |
Hm strange... In my terminal it showed that the file was executable (and I could execute it) but when checking git ls-files --stage it said that it was not executable. I managed to fix it now :) |
@macjohnny @djairhogeuens Build seems to have timed out? |
@filipvh I restarted the build |
@djairhogeuens the CircleCI tests fail due to the docs-page not being up to date. can you please fix this? |
Docs were updated but apparently the order of the parameters matters, fixed it :) |
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
@wing328 When checking in SourceTree it seems correct to me? |
@djairhogeuens thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168 |
@djairhogeuens please have a look at https://github.com/OpenAPITools/openapi-generator/pull/4479/commits and none of the commits is linked to your Github account. |
fixes #4465 Add support for singleRequestParameter in typescript-angular generator
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.